chore: (PRO-275) Set FeePayerPolicy defaults to false#217
Merged
Conversation
Changed all FeePayerPolicy default values from true to false, ensuring explicit policy configuration is required for fee payer actions. Updated related tests and documentation to reflect the new defaults.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to c4c508f in 1 minute and 40 seconds. Click for details.
- Reviewed
179lines of code in4files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_Vqg7xgvK8tsnJlO3
You can customize 
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 6eacc05 in 31 seconds. Click for details.
- Reviewed
7lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/badges/coverage.json:1
- Draft comment:
Badge updated from 85.8% to 85.6%. Ensure this value reflects the actual CI test coverage and is updated consistently if coverage generation changes. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_Aqamw2Eq0iKimdVE
You can customize
dev-jodee
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed all FeePayerPolicy default values from true to false, ensuring explicit policy configuration is required for fee payer actions. Updated related tests and documentation to reflect the new defaults.
Important
Change
FeePayerPolicydefaults to false, requiring explicit configuration for fee payer actions, and update related tests and documentation.FeePayerPolicydefaults to false inconfig.rs, requiring explicit configuration for fee payer actions.get_config.rsandtransaction_validator.rsto reflect new defaults.kora.tomlto indicateFeePayerPolicydefaults to false for security.This description was created by
for 6eacc05. You can customize this summary. It will automatically update as commits are pushed.
📊 Test Coverage
Coverage: 85.7%
View Detailed Coverage Report